Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fsclient segfaults on empy "help" argument #3

Closed
2 tasks done
dehorsley opened this issue Sep 13, 2019 · 1 comment · Fixed by #4
Closed
2 tasks done

fsclient segfaults on empy "help" argument #3

dehorsley opened this issue Sep 13, 2019 · 1 comment · Fixed by #4
Assignees
@dehorsley

Comments

@dehorsley
Copy link
Member

dehorsley commented Sep 13, 2019 •
edited
Loading

Entering "help" or "help=", causes a "help=(null)" to be sent to fsclient and then fsclient crashes.

Two things need to be fixed here:

  • "(null)" should not be sent
  • fsclient should gracefully handle helpstr_ erroring like that

Reported by Jun Yang at Onsala.
@dehorsley dehorsley self-assigned this Sep 13, 2019
@dehorsley dehorsley mentioned this issue Sep 13, 2019
Merged
@dehorsley dehorsley reopened this Sep 23, 2019
@dehorsley dehorsley mentioned this issue May 4, 2020
Closed
@dehorsley
Copy link
Member Author

Closed in favour of #40

wehimwich added a commit that referenced this issue Jan 27, 2021
@wehimwich
Increment #3 for dbbc3 for drudg
c88fb8f 
After reconstruction for lost files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dehorsley dehorsley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix oprin sending "(null)" to fsclient nvi-inc/fs
1 participant
@dehorsley