You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I discovered what appears to be a bug in the logic that is attempting to find a match to either the compatibility or full TnSpec. I think the simple fix is to add a break here:
The bug was exposed due to meta-tegra having additional bup specs that differed from the L4T 35.3.1 release (which was resolved in the PR). I was able to recreate it using the L4T release by simply adding this spec:
to the jetson-xavier-nx-devkit-emmc board of the t19x_spec in jetson_board_spec.cfg and then rebuilding the capsule per here. With the additional spec present the code will fail to break out of the loop and will match on the next entry, but since Found is now TRUE it will fall into the else clause that returns EFI_UNSUPPORTED.
The text was updated successfully, but these errors were encountered:
@Lexmark-chad the linked PR changes the loop you mention to give debug warnings if multiple matching images are in the capsule instead of rejecting the capsule with EFI_UNSUPPORTED. Thanks again for opening the issue.
While working on this pull request:
OE4T/meta-tegra#1285
I discovered what appears to be a bug in the logic that is attempting to find a match to either the compatibility or full
TnSpec
. I think the simple fix is to add abreak
here:https://github.com/NVIDIA/edk2-nvidia/blob/main/Silicon/NVIDIA/Library/FwPackageLib/FwPackageLib.c#L267
The bug was exposed due to
meta-tegra
having additional bup specs that differed from the L4T 35.3.1 release (which was resolved in the PR). I was able to recreate it using the L4T release by simply adding this spec:'boardid=3668;fab=200;boardsku=0001;boardrev=;fuselevel_s=1;chiprev=2;board=jetson-xavier-nx-devkit-emmc;rootdev=mmcblk0p1'
to the
jetson-xavier-nx-devkit-emmc
board of thet19x_spec
injetson_board_spec.cfg
and then rebuilding the capsule per here. With the additional spec present the code will fail to break out of the loop and will match on the next entry, but sinceFound
is nowTRUE
it will fall into the else clause that returnsEFI_UNSUPPORTED
.The text was updated successfully, but these errors were encountered: