Windows - MP2 Ground Zero crash when loading rlava1

[abalfoort]

Assertion failure in vertex_buffer.c:

src/refresh/vkpt/vertex_buffer.c:659: vkpt_light_buffer_upload_to_staging: Assertion `bsp_mesh->num_light_polys + num_model_lights < MAX_LIGHT_POLYS' failed.

MAX_LIGHT_POLYS is set to 4096.

Values on assertion failure:

		bsp_mesh->num_light_polys	5332	int
		num_model_lights	0	int

[abalfoort]

This only happens in Windows, not in Linux (Debian).

Originally posted here: abalfoort#7

[abalfoort]

Fixed this by increasing the MAX_LIGHT_POLYS value to 8912: commit 0eaca60

I don't know if this a preferred solution or not, but for now it seems to have solved this issue.

I'm open for better suggestions.

[apanteleev]

Thanks for reporting the issue - I just fixed it in 562d151

[abalfoort]

You chose not to increase the MAX_LIGHT_POLYS value. Is there a reason to keep the value low at 4096?

[apanteleev]

The high light count was actually a bug, the map needs 764 lights with that bug fixed. And I added a warning message if the 4k limit is ever exceeded, so the game should not crash but provide actionable info.

[abalfoort]

Tested over the past two weeks and works perfectly. Thanks!