Fix request_force_stop_sigrtmin failing for python3 #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 24, 2016 12:29
request_force_stop_sigrtmin would fail for python3 because it would try to read frame attributes that have been removed in python3 This patch fixes that by reading more fram attributes only for python2
Merged
|
Thanks! |
| 'f_lasti', 'f_lineno', 'f_locals', 'f_restricted', 'f_trace'] | ||
|
|
||
| frame_properties = ['f_code', 'f_lasti', 'f_lineno', 'f_locals', 'f_trace'] | ||
| if sys.version_info[:2] < (3, 0): |
There was a problem hiding this comment.
Would have been good to get a chance to review this, surely no need to merge it immediately?
Would it not have been better to use if PY2 from compat? That's surely what compat is there for.
There was a problem hiding this comment.
You are right, I completely forgot about compat. I'll fix that and work also on a test about it too as you suggested.
There was a problem hiding this comment.
Sorry about that, was in a hurry. Thanks for the improvements.
|
Also (and arguably the first step in fixing this) we should have a test that the error raised is indeed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signal handler request_force_stop_sigrtmin (introduced with the heroku specific worker, #715) would fail in python3 because it was trying to read frame properties that have been removed in python3.
We now handle python2 as a special case with more frame properties.
Also fixed some warnings about using the war function of the logger