Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rails 5 deprecation #209

Conversation

jeroenvisser101
Copy link
Contributor

Using ActiveSupport::Reloader instead of ActionDispatch::Reloader to be
ready when Rails 5 hits (and to prevent it from breaking when 5.1 comes
out).

DEPRECATION WARNING: to_prepare is deprecated and will be removed from Rails 5.1
(use ActiveSupport::Reloader.to_prepare instead) (called from block in <class:Railtie> at /path/to/lib/no_brainer/railtie.rb:29)

Using ActiveSupport::Reloader instead of ActionDispatch::Reloader to be
ready when Rails 5 hits (and to prevent it from breaking when 5.1 comes
out).

DEPRECATION WARNING: to_prepare is deprecated and will be removed from
Rails 5.1 (use ActiveSupport::Reloader.to_prepare instead)
(called from block in <class:Railtie> at /path/to/lib/no_brainer/railtie.rb:29)
@jeroenvisser101
Copy link
Contributor Author

It seems that JRuby failing isn't connected to this PR.

@jeroenvisser101
Copy link
Contributor Author

Fixes #205

@jeroenvisser101
Copy link
Contributor Author

@nviennot it seems to break due to the secret key being empty on jruby, not sure about that. Do you mind checking this out?

@jeroenvisser101
Copy link
Contributor Author

There still seem to be some issues. In Rails 5, I keep getting the 'already registered and partially loaded' error, which I think is due to concurrent-ruby.

@nviennot nviennot closed this in e343787 Jun 5, 2016
@nviennot
Copy link
Collaborator

nviennot commented Jun 5, 2016

Hi Jeroen :)

  • I removed jruby from travis-ci (even though the tests are running just fine locally). I don't think I want to troubleshoot the SSL erorrs it gives.
  • Merged the pull request
  • I can't reproduce the "already registered and partially loaded" error. If you want to open a new issue with some code to reproduce it, that'd be great :)

Thanks,
Nico

@jeroenvisser101
Copy link
Contributor Author

jeroenvisser101 commented Jun 5, 2016

@nviennot thanks for merging! Will see if I can get some code working next week. I've got a fork up that resolves the issue for me (not sure if it breaks other things though). If you want, you can have a look here.

@nviennot
Copy link
Collaborator

nviennot commented Jun 5, 2016

Thank you for the PR!

I'd be interesting in seeing the code that triggers the "partially loaded" error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants