New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NoBrainer validation play well with has_secure_password #129

Closed

jdrago999 wants to merge 1 commit into NoBrainerORM:master from jdrago999:patch-1

Contributor

jdrago999 commented Feb 23, 2015

No description provided.


          Make NoBrainer validation play well with has_secure_password

2f92e93

nviennot closed this in

039e119

Collaborator

nviennot commented Feb 23, 2015

I changed the code a bit:

I didn't like the blind inline rescue as it can hide some real code issues
The default return value should be true and not false so we always validate attributes for which we don't have a corresponding changed? method.
I added a test

Thanks for the PR :) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet