Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support if nvim extention is being used in vscode #934

Closed
wants to merge 1 commit into from

Conversation

sumanth-lingappa
Copy link
Contributor

@sumanth-lingappa sumanth-lingappa commented May 16, 2024

VSCODE neovim extention pre-requisite is to have nvim installed and it opens nvim's config by default in vscode.
I use both nvim and vscode depending on my project need.

Some of the nvim's UI does not work well with VSCODE.

This if-else clause will differentiate if we are using vscode or nvim directly.

Signed-off-by: Sumanth Lingappa <sumanth.lingappa@gmail.com>
@dam9000
Copy link
Contributor

dam9000 commented May 16, 2024

I don't think vscode users would be the target audience for kickstart so I'm not sure if this is really needed? In my view it just pollutes the code. Besides the suggested change is documented in the vscode neovim plugin install instruction (the link you provided) which one will have to go through and will be able to make the change for himself.

@sumanth-lingappa
Copy link
Contributor Author

I agree with your point @dam9000
For me this is a must condition clause. I thought this will be useful for others out-of-the-box.

@jiaad
Copy link

jiaad commented Jun 21, 2024

I agree with your point @dam9000 For me this is a must condition clause. I thought this will be useful for others out-of-the-box.

I also think, it should be available out-of-the-box

@feoh
Copy link
Collaborator

feoh commented Jul 21, 2024

Hi. Thank you for your contribution but making a one line change to your config as specified in the vscode neovim extension feels like the right place for this to me. As such I don't think it's compatible with our project's goals and I'm closing for now.

@feoh feoh closed this Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants