-
Notifications
You must be signed in to change notification settings - Fork 17.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neovim 0.10 updates #936
base: master
Are you sure you want to change the base?
Neovim 0.10 updates #936
Conversation
I should add that this probably shouldn't be merged too soon, since 0.10 released today, and it's probably not in many repos. But, I think these changes are fit to be in the main, since the point of kickstart is to be small and support the latest stable Neovim, and not provide a backwards compatible config that works everywhere. |
I think merging this should be delayed by a couple of months, since it will take a while for all the distributions and package managers to upgrade to the latest 0.10 release. In the meantime, the kickstart config as is works perfectly fine also on 0.10. Merging this does not fix anything but it will break functionality for people still on 0.9.5. |
In addition, if these changes are integrated then the Alternatively these changes could be made conditional with something like:
curiously, the below version check does not work for me in nvim 0.10:
any idea why? I tested it with the prebuild nvim-linux64.tar.gz 0.10 release. |
Check your |
@VlaDexa you are right, vim.version() says: |
Provide the buffer for which to enable inlay hints Co-authored-by: Matt Mirus <matt@mattmirus.com>
Regarding the delay merging the PR, the README says:
So it would make sense to merge this now or soonish IMHO. At which point do you declare it ready to go, when you say we should wait for distributions to package it? But I also see this point:
How was this handled during the 0.9 release? |
Got tired of waiting for someone to reply. If anyone wants for these commits from other PR's to not be included here please tell me. |
…erging has slowed down
That would only happen if 1) you did a Edit: You inspired me to add some more reasons to https://github.com/rmacklin/why_i_dont_recommend_squash_and_merge |
Are these going to be merged anytime soon? |
Fixes #992 |
This is a PR that cleans up the config in accordance to new stable features.
I have made the following changes:
Key Mappings:
K
,[d
and]d
mappings, since they are included by default<leader>e
mapping, because neovim started using<C-W>d
for this by defaultPlugin changes:
Comment.nvim
, since neovim now includes their commenting tool (see :help commenting)Chores:
vim.lsp.inlay_hint
presence, since stable now supports itFixes:
vim.lsp.inlay_hint.is_enabled
Accumulated PRs