Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(popup): set modifiable failed when vim.api.nvim_buf_set_lines #575

Merged
merged 12 commits into from
Apr 25, 2024
Merged

fix(popup): set modifiable failed when vim.api.nvim_buf_set_lines #575

Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bcd45b1
fix(popup): nomodifiable popup, closes #570
AlejandroSuero Apr 15, 2024
707c024
fix(popup): better `set modifiable`
AlejandroSuero Apr 22, 2024
70bd476
Revert "fix(popup): nomodifiable popup, closes #570"
AlejandroSuero Apr 22, 2024
a102c01
Merge branch 'nvim-lua:master' into feat-set-modifiable-popup
AlejandroSuero Apr 25, 2024
bd7cc58
fix(popup): removed `modifiable` check and set from previous PR
AlejandroSuero Apr 25, 2024
32c08b1
fix: added modifiable to buffer and window
AlejandroSuero Apr 25, 2024
7cab499
fix: removed modifiable from window
AlejandroSuero Apr 25, 2024
a565d9a
fix: ensure modifiable in buffers
AlejandroSuero Apr 25, 2024
62d6c80
fix: added modifiable check in window
AlejandroSuero Apr 25, 2024
8e7344d
fix: removed check in border title
AlejandroSuero Apr 25, 2024
74485db
fix: removed modifiable from `what` as `bufnr`
AlejandroSuero Apr 25, 2024
a6041d3
fix: changed it to unconditionally
AlejandroSuero Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lua/plenary/popup/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,10 @@ end
function popup.create(what, vim_options)
vim_options = vim.deepcopy(vim_options)

if vim.o.modifiable == false then
vim.o.modifiable = true
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this just enables this globally. change this setting, we probably dont want this?!


local bufnr
if type(what) == "number" then
bufnr = what
Expand All @@ -123,9 +127,6 @@ function popup.create(what, vim_options)
assert(bufnr, "Failed to create buffer")

vim.api.nvim_buf_set_option(bufnr, "bufhidden", "wipe")
if vim.o.modifiable == false then
vim.api.nvim_buf_set_option(bufnr, "modifiable", true)
end

-- TODO: Handle list of lines
if type(what) == "string" then
Expand Down
Loading