feat: add option on how to get a devicon #1133
Open
+11
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the filetype component, Lualine always gets filetype devicon by file path, and fallback to using filetype only when unsuccessful. This design leads to problems when:
.pl
which is used by both Prolog and Perl. Merely checking the file path (devicons.get_icon(vim.fn.expand('%:t'))
) will always result in Perl's devicon regardless actual filetypeMy proposal is to allow user decide how should the devicon be determined with option
get_icon_by
, with valid inputs'filename'
(traditional behaviour) or'filetype'
(prioritisingget_icon_by_filetype
overget_icon
). I'm uncertain if this change should become the default behaviour; feel free to make it so if there's no strong reason.