Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding embark theme #269

Closed
wants to merge 1 commit into from

Conversation

nadir-ishiguro
Copy link

Hi,
I've been really enjoying lualine. Thank you for your work!

I'd like to add skbolton's embark theme which I've been enjoying recently.

I followed your guideline and hope that everything is in order.

lualine_emabark_normal
lualine_emabark_insert
lualine_emabark_visual
lualine_emabark_replace

Thanks again!

@shadmansaleh
Copy link
Member

Do you want to merge this to shadmansaleh/lualine.nvim or #311 ?

@shadmansaleh
Copy link
Member

We are currently not accepting regular themes. We think themes make more sense along with colorschemes. Because the themes in this repo gets rarely updated, most of this repo is already themes and it's not possible for me to keep track if the colorscheme of the theme changes some of it's color. Many color schemes already support lualine and I'd like to encourage that.

embark seems to already support lightline & airline you could ask them to add support for lualine.

Thanks for trying to contribute :) . And sorry for late reply .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants