-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature to rename tabs #574
Conversation
Add the |
Now with |
lgtm. Thanks for taking your time to implement this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meet a situation(quite common) in which :LualineTabRename
will lead to a crash.
- create 2 tabs.
- close first tab(
:tabc
).
Then tabline get crashed.
This happen because, when closing a tab, tabnr(tabpagenr) of a tab will change(2->1). But in tab.lua, self.tabnr
does not change. So access to vim.t
will be out of index.
fixes #574 (review) Issue was neovim's tabpage handle used by rpc-api isn't same as tab no in viml. Now the tabpage handle is stores in self.tabId and tab no is stored in self.tabnr in `Tab` so any can be used when necessary.
Hi, would it possible to save tab's names when using |
* (feat) add rename * remove tabname if LualineRenameTab is ran without args * document LualineRenameTab Co-authored-by: shadmansaleh <13149513+shadmansaleh@users.noreply.github.com>
fixes nvim-lualine#574 (review) Issue was neovim's tabpage handle used by rpc-api isn't same as tab no in viml. Now the tabpage handle is stores in self.tabId and tab no is stored in self.tabnr in `Tab` so any can be used when necessary.
with