fix: prevent "too many open files" errors from git ignored check #1127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1125, fixes #997
The problem was actually cuased by calling out to git too many times when checking the git ignored status of files. This only happens when there are many folders being shown at once. The solution was to limit the number of concurrent running jobs to 50.
I also snuck in a config option to completely disable checking gitignore when searching, as this has a big performance impact on the "search as you type" mode. Personally, I'd rather it be fast than be able to mark gitignored items.
The default value is true so as not to change the existing behavior.