Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filesystem): always show gitignored status unless enable_git_status is false #1184

Conversation

cseickel
Copy link
Contributor

@cseickel cseickel commented Oct 14, 2023

fixes #1152

With this change, the gitignored status will always be loaded unless:

  • filtered_items.hide_gitignored is false AND enabled_git_status is false
  • you are doing a search and check_gitignore_in_search is false
  • there are no items to show

Note that this does not affect dotfiles, which will show as normal files when filtered_items.hide_dotfiles is false.

@cseickel cseickel enabled auto-merge (squash) October 14, 2023 18:23
@cseickel cseickel merged commit 63ebe87 into main Oct 14, 2023
4 checks passed
@cseickel cseickel deleted the 1152-bug-gitignored-files-aren-t-marked-as-such-when-hide-gitigno branch October 14, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: gitignored files aren't marked as such when hide_gitignored = true
1 participant