Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs: add how to call neotree from Lua #1188

Merged
merged 7 commits into from
Oct 20, 2023
Merged

Improve docs: add how to call neotree from Lua #1188

merged 7 commits into from
Oct 20, 2023

Conversation

artfulrobot
Copy link
Contributor

This fixes
#1153

There are two commits.

  1. Adds minimal explanation
  2. Adds example keys entry to do something useful.

@artfulrobot artfulrobot mentioned this pull request Oct 18, 2023
Closed
1 task
pysan3
pysan3 reviewed Oct 18, 2023
View reviewed changes
doc/neo-tree.txt Outdated Show resolved Hide resolved
@pysan3
Copy link
Collaborator

pysan3 commented Oct 18, 2023

I think it's good to go. @cseickel Please review this PR :)

@pysan3 pysan3 requested a review from cseickel October 18, 2023 08:58
@artfulrobot
Copy link
Contributor Author

Please hold off merging, something's not quite right (use of reveal_file is causing relative paths to be interpreted as absolute paths). Will adjust in a mo.

@artfulrobot
Copy link
Contributor Author

ok, that's fixed it.

cseickel
cseickel reviewed Oct 20, 2023
View reviewed changes
doc/neo-tree.txt Outdated Show resolved Hide resolved
cseickel
cseickel reviewed Oct 20, 2023
View reviewed changes
doc/neo-tree.txt Outdated Show resolved Hide resolved
cseickel
cseickel reviewed Oct 20, 2023
View reviewed changes
doc/neo-tree.txt Outdated Show resolved Hide resolved
cseickel
cseickel reviewed Oct 20, 2023
View reviewed changes
doc/neo-tree.txt Outdated Show resolved Hide resolved
cseickel
cseickel reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@cseickel cseickel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish more people would submit documentation PRs! I do have some comments and suggestions.

artfulrobot and others added 5 commits October 20, 2023 13:04
@artfulrobot @cseickel
Update doc/neo-tree.txt
6f037ed 
Co-authored-by: cseickel <cseickel@gmail.com>
@artfulrobot @cseickel
Update doc/neo-tree.txt
00acd2c 
Co-authored-by: cseickel <cseickel@gmail.com>
@artfulrobot @cseickel
Update doc/neo-tree.txt
f2cfeb1 
Co-authored-by: cseickel <cseickel@gmail.com>
@artfulrobot
Remove non-neo-tree 'keys' bit, replace with vim.keymap()
9d250fb
@artfulrobot
remove deprecated commands from help file
cf4fd5a
cseickel
cseickel approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@cseickel cseickel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@cseickel cseickel merged commit ecabaae into nvim-neo-tree:main Oct 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pysan3 pysan3 pysan3 left review comments

@coffebar coffebar coffebar approved these changes

@cseickel cseickel cseickel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@artfulrobot @pysan3 @coffebar @cseickel