fix(filesystem): Add new error handlers for getting directory children #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If err exists, dir is nil anyways (at least from my understanding)
cseickel
reviewed
Feb 5, 2024
pynappo
force-pushed
the
fix-get-children-async
branch
from
1c4b9aa
to
ccddfb0
Compare
cseickel
reviewed
Feb 6, 2024
pynappo
force-pushed
the
fix-get-children-async
branch
from
88bde43
to
1355385
Compare
pynappo
changed the title
get_children_async()get_children_(sync|async)()
pynappo
changed the title
get_children_(sync|async)()
pynappo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #960 but for
get_children_async.Sometimes,
get_children_asyncmay try to read from folders with restrictive permissions and libuv will error out. For example, I usescan_mode = "deep", and opening neo-tree in the Windows $HOME results in a lot of errors because Windows puts a lot of folders with restrictive permissions there (for some reason). This PR will just callback with an empty list of children in that case.On a tangential note, I think the fs_scan file could use a run of
stylua, some code seems to have extra indentation and there'sfunction (...)(note the space) instead offunction(...). I didn't want to make the diff too big for a small bugfix though.