Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(renderer): clean out edge cases of cursor.position.restore #1355

Merged
merged 7 commits into from Feb 18, 2024

Conversation

pysan3
Copy link
Collaborator

@pysan3 pysan3 commented Feb 16, 2024

We need to be more careful when to save and restore the cursor position as we cannot overwrite the position anymore with #1288.

closes #1310

Please read the LONG discussion from #1354 (comment) as it describes the issue and the reason thoroughly.

I will keep this as draft until I get some people to test this code as I might have missed some more edge cases.

Would you mind testing this code? @georgeguimaraes @mehalter @XavierChanth

{ 
  "pysan3/neo-tree.nvim",
  branch = "update-curpos-before-expand",
  version = false,

@mehalter
Copy link
Contributor

I did some testing and this does seem to fix the linked issue! ❤️

@XavierChanth
Copy link

Working wonderfully @pysan3 ! Thanks so much

@pysan3
Copy link
Collaborator Author

pysan3 commented Feb 16, 2024

Thanks @mehalter @XavierChanth !

Ready to roll @cseickel

@pysan3 pysan3 marked this pull request as ready for review February 16, 2024 16:07
@cseickel cseickel merged commit 7d3b020 into nvim-neo-tree:main Feb 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: jump to selected item when opening folder
4 participants