Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert window close buffer cleanup code #1433

Merged
merged 1 commit into from Apr 11, 2024
Merged

Conversation

cseickel
Copy link
Contributor

@cseickel cseickel commented Apr 11, 2024

fixes #1415

This reverts the renderer close function to ensure that the buffer is deleted synchronously instead of being scheduled for later. That code was originally changed as part of trying to support winfixbuf. I have confirmed that the winfixbuf situation still works correctly even with this reversion, so the change was never actually needed.

See #1418 (comment) for more background.

The one known bug that was fixed by the prior code was when you have neotree as the only open window, then open a float neotree and try to open a file. That's an odd edge case and not worth complicating the code base for. If someone can find a simple and obvious fix for that then we can address it separately.

@cseickel cseickel enabled auto-merge (squash) April 11, 2024 13:17
@cseickel cseickel disabled auto-merge April 11, 2024 13:18
@cseickel cseickel merged commit c61074a into main Apr 11, 2024
4 checks passed
@cseickel cseickel deleted the 1415-buffer-exists branch April 11, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Buffer with this name already exists after manually closing neo-tree
1 participant