fix: revert window close buffer cleanup code #1433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1415
This reverts the renderer
close
function to ensure that the buffer is deleted synchronously instead of being scheduled for later. That code was originally changed as part of trying to supportwinfixbuf
. I have confirmed that thewinfixbuf
situation still works correctly even with this reversion, so the change was never actually needed.See #1418 (comment) for more background.
The one known bug that was fixed by the prior code was when you have neotree as the only open window, then open a float neotree and try to open a file. That's an odd edge case and not worth complicating the code base for. If someone can find a simple and obvious fix for that then we can address it separately.