-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(symbols): Added symbol source #841
Conversation
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First off, it's awesome that you are undertaking this, I can't wait to start using it!
I do think there is more work to do before it's ready for merging though. I haven't dug deep into the code but I have some suggestions at the surface level here.
I also noticed that it does not automatically update when I change files, which is something that I think would be expected by anyone using it.
I'm very glad to hear that you like this! Regarding the automatic update, I will have a look at why it is not auto-updating. Previously, I used the |
@cseickel I can't seem to reproduce your issue with automatic file changes. For me, whenever I change the file, the Edit: Actually, undoing doesn't refresh this, and it seems that there is no other way to hook onto undoing, so I'm falling back to using the |
Actually, I ended up changing it to several separate events and using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@nhat-vo I think this looks good as an initial release and I'll merge it now. The two things I would add to make it complete are:
|
@cseickel Great! I'm very glad to see this merged! I'll create an issue to track the features of this source. |
A simple source to view LSP symbols in the current file.
Features:
open_split
and friends)rename
)preview
and friends)Feel free to let me know if you have any comments on what additional features should be desired.