fix(source_selector): fix bug with tabs_layout #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually I realized that I made the wrong implementation but haven't got time to redo it, so this shouldn't be merged yet.😓 |
nhat-vo
changed the title
Can you mark this as a "draft" PR to make it clearer that it's not ready? |
nhat-vo
changed the title
|
@cseickel This should be ready for review. |
cseickel
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #848.
The function
text_layoutdoesn't work with the whole tab representation, which relies onvim.fn.strdisplaywidth. It seems that this function considers the tab representation string literally, and gives a length of more than 400 for just 3 tabs. Thetext_layoutthen truncates the tab representation, which results in weird values.To fix this, I moved the
text_layoutlogic to truncatetab.textinstead.