fix: set correct winid when window.position = current #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cseickel
reviewed
Apr 16, 2023
cseickel
reviewed
Apr 17, 2023
cseickel
reviewed
Apr 18, 2023
lua/neo-tree/setup/netrw.lua
Outdated
| @@ -5,14 +5,15 @@ local command = require("neo-tree.command") | |||
| local M = {} | |||
|
|
|||
| local get_position = function(source_name) | |||
| local pos = utils.get_value(M, "config." .. source_name .. ".window.position", "left") | |||
| local nt = require("neo-tree") | |||
| local pos = utils.get_value(nt.config, source_name .. ".window.position", default_pos, true) | |||
There was a problem hiding this comment.
It doesn't actually have any effect with how this is used right now, but I think the default_pos variable is undefined here and should be replaced with "left".
There was a problem hiding this comment.
Right, fixed that now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #845 and #822
:Neotreeand the defaulthijack_netrwbehaviour would fail ifconfig.window.postion = current. It seems that bothexecuteincommand/init.luaandhijackinsetup/netrw.luadidn't set the correct winid in state whenconfig.window.position = current. Changes to fix this are minimal and just involve getting the window position from the config.This is my first PR to open source 馃コ and I'm quite new to neovim plugin development, any feedback would be appreciated.