feat(ui): hide hidden files irrespective of hide_gitignored option

[pysan3]

closes #929

Note

show_anyways is only used in this context (there is no other reference to show_anyways other than my fix), so deleted in line 200.

[cseickel]

I don't understand how this would fix the problem described in the bug. I expected the fix to be that the choice of whether to hide something be fixed in renderer.lua --> remove_filtered only so that some choices take precedence over others.

[pysan3]

I'm sorry @cseickel

Forgot to turn it into a draft.

I was intending to first get a reply over on the issue and then start working on it.

[cseickel]

I was intending to first get a reply over on the issue and then start working on it.

Ah, well yes, I do think this is something that should be fixed!

[pysan3]

Hey @cseickel I've got a question,

With further exploration, I think the easiest way would be to skip updating item.filtered_by.gitignored by short circuiting everything here.

neo-tree.nvim/lua/neo-tree/git/ignored.lua

Lines 86 to 102 in e5594d5

	local function finalize(all_results)
	local show_anyway = state.filtered_items and state.filtered_items.hide_gitignored == false
	log.trace("IGNORED: Comparing results to mark items as ignored, show_anyway:", show_anyway)
	local ignored, not_ignored = 0, 0
	for _, item in ipairs(items) do
	if M.is_ignored(all_results, item.path, item.type) then
	item.filtered_by = item.filtered_by or {}
	item.filtered_by.gitignored = true
	item.filtered_by.show_anyway = show_anyway
	ignored = ignored + 1
	else
	not_ignored = not_ignored + 1
	end
	end
	log.trace("IGNORED: mark_ignored is complete, ignored:", ignored, ", not ignored:", not_ignored)
	log.trace("================================================================================")
	end

I at first thought this would affect other places since it does not flag filtered_by.gitignored, but in fact this is what is done for other hide_* configs so I think it is rather a feature? config.hide_dotfiles == false makes it never update filtered_by.hidden in the first place.

neo-tree.nvim/lua/neo-tree/sources/common/file-items.lua

Lines 139 to 146 in e5594d5

	if f.hide_dotfiles and string.sub(name, 1, 1) == "." then
	item.filtered_by = item.filtered_by or {}
	item.filtered_by.dotfiles = true
	end
	if f.hide_hidden and utils.is_hidden(path) then
	item.filtered_by = item.filtered_by or {}
	item.filtered_by.hidden = true
	end

Theoretically this short circuit will be a breaking change, but I would say that updating filtered_by.gitignored when config.hide_gitignored == false was unnecessary in the first place.

Would you agree with this fix @cseickel ?

Another option would be to add if-elses here as below. Which however I feel is a bit inconsistent.

Which one would you prefer?

[pysan3]

@cseickel Any updates?

[cseickel]

The part you have to consider is that even when a gitignored item is visible, we still need to be able to mark it as ignored in the name and git_status components so it shows with teh right font and with the correct status symbol.

Your second proposal is the correct strategy. I don't know for sure if the logic is correct or not (short on time), but it is definitely the right place to handle this.

[pysan3]

@cseickel Thanks for the response.

Your second proposal is the correct strategy

I've updated the code and is ready to be merged :)

[cseickel]

You're on a roll @pysan3!