Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(document_symbols): add_blank_line_at_top #972

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

nhat-vo
Copy link
Collaborator

@nhat-vo nhat-vo commented Jun 6, 2023

Fix the bug when add_blank_line_at_top = true as mentioned in #879.

@cseickel cseickel merged commit d883632 into nvim-neo-tree:main Jun 6, 2023
3 checks passed
@MunifTanjim
Copy link
Contributor

btw, add_blank_line_at_top can probably be supported by doing tree:render(2) instead of adding extra dummy nodes to the tree.

@cseickel
Copy link
Contributor

cseickel commented Jun 8, 2023

Thanks for the heads up @MunifTanjim! We should probably do this at some point, but I tried to do it quickly and it didn't work out. There seems to be other code in neo-tree that assumes certain things about the number of nodes in the tree vs linenr. Also, any sort of re-render in the same window just added new copies of the tree below the old one.

If anyone else wants to take that on, go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants