fix: cursor behavior on link insertion #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use `feedkeys` with mode "n" instead of "t" -> more robust against user remaps - only go into insert mode when executed from insert mode - make `put` behave like `p` and not `P`
|
@vhyrro can you take a look at this since you initially wrote that function? |
|
Sorry for taking this long. Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi; this PR fixes the cursor behavior when users had some of the keys remapped that where fed via
nvim_feedkeys. It should also fix #37.However, note that to do this I basically changed
nvim_feedkeys("hf]a", "t")tonvim_feekeys("a", "n"). Why was "hf]" there in the first place; shouldn'tnvim_put("...", false, true)place the cursor at the end of the inserted text anyways, or am I'm missing some edge cases here? I'm a little bit uncertain about that.Additionally, the behavior is changed such that insert mode is only entered if the action was started from insert mode, and the putting behaves like
pinstead ofP. The latter change is debatable, but for me at least, it felt more natural that way; if you think differently I'll change it back.