Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docgen): inline esupports.metagen template function definitions #945

Merged
merged 1 commit into from
Jul 7, 2023
Merged

fix(docgen): inline esupports.metagen template function definitions #945

merged 1 commit into from
Jul 7, 2023

Conversation

jneidel
Copy link
Contributor

@jneidel jneidel commented Jun 14, 2023

So they show up in the wiki.

Current state

Here in the wiki for the default implementation in the template it only show the function() part:
screenshot_23-06-14_18:50:40
That it is only saying function() is just confusing.

Desired state

I would like to see the full function definition, so I can copy over the ones that I like and adjust what I don't like in my config:
screenshot_23-06-14_19:03:18

@jneidel
Copy link
Contributor Author

jneidel commented Jun 14, 2023

@vhyrro You're doing a great job with the youtube videos! Without them the project would be significantly harder to get into.

@max397574
Copy link
Contributor

this is nice ig
but I think this is also something that should be fixed in the docgen

@jneidel
Copy link
Contributor Author

jneidel commented Jun 15, 2023

I think this is also something that should be fixed in the docgen

That would probably be a better solution in the long-term 😄

@vhyrro
Copy link
Member

vhyrro commented Jul 7, 2023

Thanks for the temporary fix! Functions with an immediate return will be resolved in the docgen soon enough, I added it to my TODO list :)

@vhyrro vhyrro changed the title Inline esupports.metagen template function definitions fix(docgen): inline esupports.metagen template function definitions Jul 7, 2023
@vhyrro vhyrro merged commit a993b35 into nvim-neorg:main Jul 7, 2023
2 checks passed
@jneidel jneidel deleted the patch-1 branch July 8, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants