Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: register Neorg filetype in plenary.filetype #1157

Closed
wants to merge 1 commit into from

Conversation

kashelkin
Copy link

It lets Telescope detect Neorg files and attach Treesitter highlighting to preview buffers.

It lets Telescope detect Neorg files and attach Treesitter highlighting
to preview buffers.
@max397574
Copy link
Contributor

max397574 commented Nov 11, 2023

I'm not sure if we want this because it would be like a duplicate after 0.10 release
edit: nvm I got an idea

@vhyrro
Copy link
Member

vhyrro commented Nov 14, 2023

Hey!

This is a good idea on the surface but Neorg is slowly depending less and less on plenary and I don't fancy making it a hard dependency once again. Unsure why telescope uses a filetype detection system that isn't the native one but a wrapper/extension on top of it 😅.

I think the best course of action is to wait for Neovim 0.10.0 where norg becomes an officially recognized filetype and where more than one filetype hook is not required any longer.

Thank you for the PR but I don't see this being the proper solution :)

@vhyrro vhyrro closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants