Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): fold shows heading icons #157

Merged
merged 1 commit into from
Oct 13, 2021
Merged

feat(ui): fold shows heading icons #157

merged 1 commit into from
Oct 13, 2021

Conversation

kkharji
Copy link
Contributor

@kkharji kkharji commented Oct 13, 2021

Purpose

Keep showing user customized heading icons in folds.

Screen Shot 2021-10-13 at 3 23 39 AM

To achive same results:

vim.cmd[[hi Folded gui=bold guibg=NONE]]
vim.cmd[[set fillchars+=fold:\ ]]

@kkharji kkharji changed the base branch from main to unstable October 13, 2021 00:21
@kkharji
Copy link
Contributor Author

kkharji commented Oct 13, 2021

It would be cool to figure out how to keep the colors the same with/without folds. Also, it highlight the whole fold with something like the hack done with codeblocks "dark". But I think this can be for another PR. Unless, there's a easy solution

@vhyrro
Copy link
Member

vhyrro commented Oct 13, 2021

Looks great! I'll merge this as is right now. I might expand this later to also include other foldable elements because why not :)

As for the background highlight stuff to my understanding you can't do that since Folded is a single highlight group. You can't change the colour of an individual fold to my knowledge :(

Thanks again!

@vhyrro vhyrro merged commit 1ab281a into nvim-neorg:unstable Oct 13, 2021
@kkharji kkharji deleted the feat/ui/fold_shows_heading_icons branch October 13, 2021 17:21
@kkharji kkharji mentioned this pull request Nov 9, 2021
1 task
vhyrro pushed a commit that referenced this pull request Jan 24, 2022
esquires pushed a commit to esquires/neorg that referenced this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants