Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Tests cannot be found on windows, due to usage of \ instead of / in the file path. #44

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DasOhmoff
Copy link

Fixes #42

Should now work on all platforms, I assume

@DasOhmoff
Copy link
Author

By the way, vscode had a similar issue. Maybe this link is somehow helpful.

@haydenmeade
Copy link
Collaborator

@DasOhmoff
Copy link
Author

I do think so, but I am not 100% sure. Maybe this might create a bug at some unexpected place, but yet I was not able to find anything like it.

@brandonbarkerRAC
Copy link

changing string.gsub(pos.path, '\\', '/') to vim.fs.normalize(pos.path) will achieve this slightly more idiomatically.

Too add to this. Yes it is only needed in the case of windows, but will leave other formats unaffected.

Would love to have this working on windows :)

@kipelovets
Copy link

There's still a problem running tests on Windows, maybe this could be merged?

@bad4iz
Copy link

bad4iz commented Jan 24, 2024

this is very relevant and necessary. How are things progressing on this issue?

@conermurphy
Copy link
Contributor

@bad4iz, have you tried running this locally as the vim.fs.normalize that was introduced in #91 should fix this issue.

There is a separate issue I believe regarding other special characters such as []() which I've addressed in a PR #109.

@haydenmeade, can this issue (#44) be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests cannot be found on windows, due to usage of \ instead of / in the file path.
6 participants