fix: importing neotest-plenary causing lua print() broken #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon require("neotest-plenary"), lua global `print()` (and hence all
lua-based I/O) gets broken. This is because the module "plenary.busted"
overrides and shadows global `print()` as a side-effect.
This is a regression since nvim-neotest#10.
Solution: The module "plenary.busted" should never be imported.
wookayin
referenced
this pull request
Sep 29, 2023
Currently plenary adapters won't work out of box because plenary.nvim is not added to vim &runtimepath or lua package.path (#4). Without any config, test will fail with the error: .../neotest-plenary/run_tests.lua:26: module 'plenary.busted' not found: ^Ino field package.preload['plenary.busted'] Instead, we can get the path where plenary.nvim is installed and inject the path when running a headless neovim instance for testing. With this, neotest-plenary can run plenary.busted tests out-of-box even if users do not configure `{ min_init = ... }`. Also add some sensible options (no shada, no swapfile) to the command line. Fixes #4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon require("neotest-plenary"), lua global
print()(and hence alllua-based I/O) gets broken. This is because the module "plenary.busted"
overrides and shadows global
print()as a side-effect.This is a regression since #10.
Solution: The module "plenary.busted" should never be imported.