find_file errors if in a folder with special characters

[AvarianKnight]

Description

This is likely related to #2345

If a file has brackets and a dash in the name, using find_file will result in Reverse range in character class here

Applying the same fix as #2345 local cwd = vim.fn.expand(vim.fn.escape(opts.cwd or vim.loop.cwd(), "$?*[]")) fixes this issue, though I'm not entirely sure if this breaks any intentional functionality.

Neovim version

NVIM v0.10.0-dev-856+ge928161bd
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

Operating system and version

WSL Fedora release 38 (Thirty Eight)

Telescope version / branch / rev

telescope 0.1.x

checkhealth telescope

telescope: require("telescope.health").check()

Checking for required plugins ~
- OK plenary installed.
- OK nvim-treesitter installed.

Checking external dependencies ~
- OK rg: found ripgrep 13.0.0
- WARNING fd: not found. Install [sharkdp/fd](https://github.com/sharkdp/fd) for extended capabilities

Steps to reproduce

1. mkdir '[will-fail]'
2. cd '[will-fail]'
3. nvim inside of the directory
4. lua require('telescope.builtin').find_files()
5. error 😢

Expected behavior

Expect to be able to find files inside the directory

Actual behavior

If a file has brackets and a dash in the name, using find_file will result in Reverse range in character class

Minimal config

vim.cmd [[set runtimepath=$VIMRUNTIME]]
vim.cmd [[set packpath=/tmp/nvim/site]]
local package_root = '/tmp/nvim/site/pack'
local install_path = package_root .. '/packer/start/packer.nvim'
local function load_plugins()
  require('packer').startup {
    {
      'wbthomason/packer.nvim',
      {
        'nvim-telescope/telescope.nvim',
        requires = {
          'nvim-lua/plenary.nvim',
          { 'nvim-telescope/telescope-fzf-native.nvim', run = 'make' },
        },
      },
      -- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. '/plugin/packer_compiled.lua',
      display = { non_interactive = true },
    },
  }
end
_G.load_config = function()
  require('telescope').setup()
  require('telescope').load_extension('fzf')
  -- ADD INIT.LUA SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
end
if vim.fn.isdirectory(install_path) == 0 then
  print("Installing Telescope and dependencies.")
  vim.fn.system { 'git', 'clone', '--depth=1', 'https://github.com/wbthomason/packer.nvim', install_path }
end
load_plugins()
require('packer').sync()
vim.cmd [[autocmd User PackerComplete ++once echo "Ready!" | lua load_config()]]

[AvarianKnight]

This seems to be an issue in a few places, wonder if a helper for vim.fn.expand would be a better idea, though I wouldn't know where to start.

If you have '[will-fail]' with a file in it you also

• won't be able to preview the files content, it will just show blank.
• won't be able to use require('telescope.builtin').buffers() it'll show Reverse range in character class
• won't be able to use require('telescope.bultin').live_grep() it'll show Reverse range in character class

[jamestrew]

Hey yeah this is a regular occurrence I've been noticing that's been hard to fix due to how widespread our usage of expand. It's very easy to "over-fix" so to speak.

#2628

I have this PR but it looks like I might be missing some instances.