Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix reverse range in character class error #2345

Merged
merged 2 commits into from
Feb 19, 2023

Conversation

tido64
Copy link
Contributor

@tido64 tido64 commented Jan 23, 2023

Description

vim.fn.expand seems to be interpreting brackets ([]) as something special. Escape the filename before trying to expand.

Fixes #2233
Fixes #2315

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Create files with brackets in the filename, e.g. [2023-01-23] Test.md, and try previewing it.

Configuration:

  • Neovim version (nvim --version):
NVIM v0.8.2
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by brew@Ventura

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/Cellar/neovim/0.8.2/share/nvim"

Run :checkhealth for more info
  • Operating system and version: macOS Ventura 13.1

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

@Conni2461
Copy link
Member

thanks for fixing this :)

i tried to debug it in #1584 but never really got the required information, so thanks for doing that for me :)

@Conni2461 Conni2461 merged commit ad37745 into nvim-telescope:master Feb 19, 2023
Conni2461 pushed a commit that referenced this pull request Feb 19, 2023
@tido64 tido64 deleted the tido/fix-reverse-range branch February 20, 2023 07:39
@tido64
Copy link
Contributor Author

tido64 commented Feb 20, 2023

thanks for fixing this :)

i tried to debug it in #1584 but never really got the required information, so thanks for doing that for me :)

Thanks for reviewing!

AvarianKnight added a commit to AvarianKnight/telescope.nvim that referenced this pull request Aug 29, 2023
- this applies the same fix in nvim-telescope#2345 to make_entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants