Full width select

[TC72]

New PR.

[fdschmidt93]

Thanks taking another crack at this :)

I think what Conni meant with version bump entails:

• grep for nvim-0.5 and replace with nvim-0.5.1 (for has).
• updating https://github.com/nvim-telescope/telescope.nvim#getting-started

E: Thinking about it, maybe that's split out better into two PRs, one with version bump with breaking git commit message and the full width selection.

[Conni2461]

We can also do 1 PR with 2 commits and we dont squash

[fdschmidt93]

Ah yes, simple solutions 😆 😅

[TC72]

Looks like the 0.5.1 requirement is making a test fail, I'll check.

Edit: yes, the test is using neovim 0.5.0m same for failing mac os test.

Run sudo apt-get update
  sudo apt-get update
  sudo apt-get install -y fd-find
  test -d _neovim || {
    mkdir -p _neovim
    curl -sL https://github.com/neovim/neovim/releases/download/v0.5.0/nvim-linux64.tar.gz | tar xzf - --strip-components=1 -C "${PWD}/_neovim"
  }
  mkdir -p ~/.local/share/nvim/site/pack/vendor/start
  git clone --depth 1 https://github.com/nvim-lua/plenary.nvim ~/.local/share/nvim/site/pack/vendor/start/plenary.nvim
  git clone --depth 1 https://github.com/kyazdani42/nvim-web-devicons ~/.local/share/nvim/site/pack/vendor/start/nvim-web-devicons
  ln -s $(pwd) ~/.local/share/nvim/site/pack/vendor/start
  shell: /usr/bin/bash -e {0}

Also from Conni's note, should I have done a commit where I explicitly say "Update plugin requirement to nvim 0.5.1"?

[fdschmidt93]

Also from Conni's note, should I have done a commit where I explicitly say "Update plugin requirement to nvim 0.5.1"?

Yes, two commits (ideally not but not necessarily in order):

1. BREAKING: bump minimum nvim version to 0.5.1 (then e.g. Packer highlights these)
2. feat: full-width hl of selection

I realize that requires a bit of git-gymnastics; that's why I thought it's just suggested to bump in a separate PR.

Not sure, but we might want to have a sticky issue with breaking changes as well.

[TC72]

OK, I removed the version bump from this PR and created this one: #1405

[Conni2461]

Thanks :)

FWIW the "git-gymnastics" should have been the easier route. Less branch switching, etc. 😆