breaking: remove file browser #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet, I was just checking to make sure this was getting deleted. The only thing I was wondering was if there was a way that we could let people know that it's in an extension now when they try and do Thanks for doing this :) new extension looks good. |
|
I'd say let's have
Thoughts? |
|
👍 |
ineol
reviewed
Jan 5, 2022
doc/telescope.txt
Outdated
| @@ -2367,7 +2339,7 @@ work and make it really easy create new previewers. | |||
|
|
|||
| Furthermore, there are a collection of previewers already defined which can be | |||
| used for every picker, as long as the entries of the picker provide the | |||
| necessary fields. The more important ones are | |||
| necessary fields. The more important once are | |||
There was a problem hiding this comment.
This is not a change I've made, but I guess must have got intertwined with the state of master this branch is based off of.
Thanks for pointing it out! I'll merge sure this is untouched when I rebase prior to merging this PR (hopefully soon :)
fdschmidt93
force-pushed
the
chore/remove-file-browser
branch
from
0421c33
to
f09a679
Compare
fdschmidt93
force-pushed
the
chore/remove-file-browser
branch
from
f09a679
to
75f838a
Compare
|
Apologies this took quite a bit longer than I originally planned. |
aenichols
pushed a commit
to aenichols/telescope.nvim
that referenced
this pull request
Jan 13, 2022
…nvim into nvim-telescope-master * 'master' of https://github.com/nvim-telescope/telescope.nvim: break!: remove file_browser from builtins (nvim-telescope#1453) Revert "fix: folding when a file is opened (nvim-telescope#1643)" (nvim-telescope#1673) feat: tiebreak config function (nvim-telescope#1401) fix(builtin.treesitter): make sure that kind is not nil fix: folding when a file is opened (nvim-telescope#1643) fix: documentation for lsp_range_code_actions (nvim-telescope#1644) fix: allow `which_key` action without preview (nvim-telescope#1668)
razak17
pushed a commit
to razak17/telescope.nvim
that referenced
this pull request
Feb 1, 2022
The file_browser now has been fully removed. Please move to github.com/nvim-telescope/telescope-file-browser.nvim for a more featureful extension that replaces the builtin file browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
builtin.file_browserwill be spun off into its own extension: https://github.com/nvim-telescope/telescope-file-browser.nvim (not yet accessible to public) The extension will incorporate a lot of demanded features and essentially constitutes #1257.Hence, it makes sense to cut out the picker from
telescope-core. Note that the PR should not yet be merged but is a prep for the initial release of the extension, which will happen throughout the upcoming week.(Cutting out is also necessary, such that
:Telescope file_browseradequately forwards to the extension.)