fix: previewer if cwd is not curr dir #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
path needs to be expanded for filereadable and isdirectory
Conni2461
force-pushed
the
fix/previewer_other_cwd
branch
from
987feab
to
74c267b
Compare
Conni2461
added a commit
that referenced
this pull request
Aug 10, 2022
path needs to be expanded for filereadable and isdirectory (cherry picked from commit 8746347)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
path needs to be expanded for filereadable and isdirectory
fix #2077
Edit: this might be a bad fix with the get_buffer_by_name in mind. Because get_buffer_by_name doesn't validate (i think) and normal does, causing a problem that the result might be difficult and we get a cache miss.