Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pickers): display preview title at the same position as results title for bottom_pane layout #2494

Merged
merged 1 commit into from
May 14, 2023

Conversation

folliehiyuki
Copy link
Contributor

Description

Here is the current behavior of bottom_pane layout:

  • When prompt_position = 'bottom'. Results and preview title are both at the top:

2023-05-07-14:46:20+07

  • When prompt_position = 'top' (default). Preview title is displayed at the top, while results title is at the bottom (pretty out of place):

2023-05-07-14:49:31+07

And here is how it looks with this change:

2023-05-07-14:58:49+07

This is a really small change for the position of the preview title of bottom_pane layout. I know the bottom_pane layout function can be overridden within my personal config, but I think this should be the default for consistency, considering that all the other layouts display the titles at the same position (normally at the top of the popup).

Type of change

A subjective aesthetics change.

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

@Conni2461
Copy link
Member

Thanks :)

@Conni2461 Conni2461 merged commit d5bef7c into nvim-telescope:master May 14, 2023
8 checks passed
Conni2461 pushed a commit that referenced this pull request May 14, 2023
…itle for bottom_pane layout (#2494)

(cherry picked from commit d5bef7c)
abelmul pushed a commit to abelmul/telescope.nvim that referenced this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants