If wildignore is set to tags expand will return '' unless true is passed

[Conni2461]

We could also move to a plenary job @tami5
And fix ordinal. So don't merge
Thanks for the bug report @yujinyuz

[yujinyuz]

Looks good to me!

But maybe it should be ordered by the result and then their length? e.g. Badge should come first before BadgeLabel

or maybe I need to set it in my config?

[kkharji]

@yujinyuz agree
@Conni2461 I kinda agree with you on it becoming a more like a ctags plugin, but such an automation is important. Is it worth it create an extension for telescope that does that in addition to relocating the tags picker there "finally a test case for tj extension feature😂"

Edit: also for the plenary job related stuff, I can work on it, perhaps a joint pr? just open a new branch under this repo when you need my help

[kkharji]

@tjdevries we neeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeed gitter setup for telescope, our prs are becoming chatrooms

[Conni2461]

I am not that familiar with what is going on in sorters. I haven't worked on that part 😄.
I think we calculate a score for each entry and if the score is higher than we will rank it higher. It seems that BadgeLabel has a higher score because it also matches the ge from the file.

@tami5 You could work on a extension for that but i think we should keep tags here and than extend it in an extension. Also Tj already has two possible extension he can work with vimspector and i wrote a dap extension.
Tami i'm sooooooo sorry. I already have the jobs thing up and running but if you want some work to do. I am fine with not pushing and you can have that PR 😄 I can also walk you through

[Conni2461]

@tami5 You actually don't have to do almost anything. Look at lua/telescope/builtin/init.lua and what tj does with finders.new_oneshot_job
I believe you can figure it out tami. I am gone for like 90 mins. You should be allowed to just push to this PR or you could open a new PR and copy my fixes and we can close this one. Either way. Have fun 😄

[kkharji]

@tami5 You actually don't have to do almost anything. Look at lua/telescope/builtin/init.lua and what tj does with finders.new_oneshot_job

I'm lost , 😂 you need to accomplish something with function?

[Conni2461]

That was on sync. I just updated my last post. Tj did the heavy lifting with new_oneshot_job. You just have to read the file. So a fitting command would be cat. The plenary job will than add each element to the table when it is printed to std out.
You might wanna take a look at jobs specs.
And don't forget to add the entry_maker to opts. So new_oneshot_job can use it.
If that all works you will get an error pointing to entry_display.lua because we are not allowed to call any vimL in an async job so you wanna replace the vim.fn with the lua style of getting the string length. We have to talk about that one later
I am back in 90 mins. Sorry

[kkharji]

Sorry, still lost :$ on what is need to be accomplished
FYI: invited you on gitter

[Conni2461]

Closing in favor of #274