Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils, mark picker): preserve uri in path_expand, use it in mark picker #3029

Merged
merged 1 commit into from Apr 5, 2024

Conversation

gzbfgjf2
Copy link
Contributor

@gzbfgjf2 gzbfgjf2 commented Apr 3, 2024

Description

Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context

Fix #3023, use the approach suggested in pull request #3024.

This commit lets mark picker preserve uri.

It firstly lets utils.path_expand() return early when input is uri, then it uses utils.path_expand() in mark picker.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Original marked oil and fugitive buffers are opened as expected.

Configuration:

  • Neovim version (nvim --version):
NVIM v0.9.5
Build type: Release
LuaJIT 2.1.1703358377
  • Operating system and version:
macOS 14.4.1

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • [ n/a] I have commented my code, particularly in hard-to-understand areas
  • [ n/a] I have made corresponding changes to the documentation (lua annotations)

@jamestrew
Copy link
Contributor

Thanks!

@jamestrew jamestrew merged commit d26b666 into nvim-telescope:master Apr 5, 2024
5 of 6 checks passed
@gzbfgjf2 gzbfgjf2 deleted the fix/path-expand-uri branch April 5, 2024 01:06
Conni2461 pushed a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The mark picker over-normalises filenames, e.g., oil.nvim buffer
2 participants