LuaTreeFindFile doesn't always work

[akinsho]

Thanks for fixing #9 so quickly 🙌 .

I ran into another issue FYI 😅, when buffers from different repositories are open, nvim-tree doesn't move to the current project root (or alternatively the directory that contains the file). The GIF below hopefully shows what I mean. The first buffer in the GIF is my dotfiles repo, but I opened vim in a dart project repo. LuaTree sticks to the initial directory, and when I move into the dotfiles project it doesn't change the tree to show the new dir.

Note: using LuaTreeFindFile in a buffer in a different project than lua tree does nothing

Still reading through the code so not exactly sure what is going on yet. Looks like maybe ROOT_PATH isn't being updated when you enter a new dir 🤷‍♂️

[akinsho]

If you point me in the right direction I can take a look if that would help? Might take me a bit to figure out how it works first

[kyazdani42]

Thanks for making so detailed issues :)
Well i can take a look, the code is a little bit nasty imo so it might be easier for me to fix this !

[kyazdani42]

i hate lua regex matching.
If it's not fixed on your end, reopen this

[akinsho]

Thanks for the quick PR @kyazdani42 just tested it locally and seems to still be happening

[kyazdani42]

mmh strange i cannot reproduce the issue anymore.
Well if you want to take a look at the find_file function in lua/lib/state.lua, your issue should be located around

if node.relpath and relpath:find(utils.path_to_matching_str(node.relpath)) then

where relpath is the relative path of the node, and path_to_matching_str a function replacing - and . characters with %- and %. for lua to match paths properly in string:find.
The function itself is a bit clunky, but the only part that failed me a few times is this if condition.

[kyazdani42]

Are you running macos or linux ?

[akinsho]

Are you running macos or linux ?

I'm on Ubuntu 20.04

It looks like lua tree uses the dir that vim was opened from and sticks with that regardless of what buffer you are in, not sure if that is the intended behaviour?

My assumption was that if I opened vim in say ~/myproject/ it would change the lua tree dir depending on the buffer I was editing. In my case I navigated to ~/.dotfiles/vim/init.vim so I expected the root dir would change to either be ~/.dotfiles since it is a repo but granted doing project dirs is maybe an extra feature, then maybe the root dir would be ~/.dotfiles/vim but the lua tree stays in ~/myproject/.

[akinsho]

Alternatively maybe lua tree should just follow vim's dir and then users can use settings like autochdir or plugins like vim-rooter 🤷

[kyazdani42]

So it is a different kind of issue, indeed this plugin uses the default dir where it was opened.
I stick with that because sometimes i'm in a project, and i want to open the tree in a subdirectory (and i dont want the tree to go to the root of the project).
I could add an option for that though, should be simple to fix.

Also multiple projects is a feature i didn't think about, but it would be quite hard to implement in the current state, it would require a different implementation.
I was thinking of doing a big refactoring soon, to make the code better and the plugin more stable, and i'd also like to use vim nightly features (because its much more convenient).
I might add the feature to the refactoring if i find a proper way to implement it.

[akinsho]

One way that I've seen this solved is in defx you can pass an argument to the launch command like LuaTree --path=("user_finds_path") maybe that's a cheaper way to solve the problem or maybe it's just as complex, not sure

[kyazdani42]

well i prefer classic g: options, its easier to manage in my opinion

[kyazdani42]

oh my bad i just realized i didn't understand your issue at all. I'm gonna fix this asap sorry !

[kyazdani42]

it's fixed, i will add support for multiple workspaces one day, thanks for the tip ;)

[akinsho]

Ah I actually didn't really mean more than one workspace tbh, although if you mean like vscode that might be cool. I basically just meant when you open Lua Tree in a buffer the root directory should be the one of the current buffer. I tried master but it didn't resolve it unfortunately. I made a PR #13 which works for me locally. Let me know what you think 👍