#837 search subdirs

[alex-courtis]

It is possible that I am missing the point, however it seems to me that search is not working.

Changes:

• rewrote to use filesystem search; node search was problematic and complex
• matches input that exactly matches the end of a path e.g. file1 dir1/ dir1/file11 but not ir1/file11 or le11
• adds :find style command line completion for all files under cwd

Resolves:

• bug in which searching would result in two nodes would be created for the same file

Does not:

• search under the current node; searches under cwd; this could be added

Exposed:

• find-file bug around symlinks #837 find file symlinks fixes #1093

[kyazdani42]

indeed seemed like it wasn't working. Good idea to fallback to find_file

[be-ndee]

Okay, maybe I gave the action a miss leading name :-D A better name would have been "go to file". So my intention was that you can enter a path to jump to that directory/file in the tree. So you don't have to click or navigate through the whole tree. But "your" search is also a good feature. But it would be good, that the search checks the options for ignored files. Because I have a node_modules directory, which is in the gitignore and not visible for me in the tree, but the search searches in the node_modules, so it's quite slow.

[kyazdani42]

why not just using / then ? I don't understand the point of just moving the cursor to a file ? The search should not search inside ignored directories right ?

[alex-courtis]

Raised #1099

2 seems like a workable solution, however I have a feeling that there is something simpler.

[alex-courtis]

why not just using / then

That matched the functionality of S when I was testing. Finding files by name in subdirectories was not working.

It seems that I was misunderstanding the purpose of S. Please accept my apologies @be-ndee