Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#791 add profiling for some operations #1108

Merged
merged 3 commits into from Mar 26, 2022
Merged

Conversation

alex-courtis
Copy link
Member

Add timing to some operations. We can add more if more slow operations are identified.

Should help us with #791

@@ -13,6 +14,8 @@ function M.fn(fname)
end
running[fname] = true

local ps = log.profile_start("find file %s", fname)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being invoked (with draw) twice when

		update_focused_file = {
			enable = true,
			update_cwd = true,
		},

That might explain some of the slowness in #791.

Either way, we probably should fix that ;)

Copy link
Member

@kyazdani42 kyazdani42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition thanks :) I think the timing could've been made with the libuv but we'll see if this is needed in the future

@kyazdani42 kyazdani42 merged commit 54c78db into master Mar 26, 2022
@alex-courtis
Copy link
Member Author

I think the timing could've been made with the libuv

Indeed. I looked at :help but didn't look at vim.inspect(vim) 🤦

#1110

@kyazdani42 kyazdani42 deleted the #791-update_cwd-logging branch April 30, 2022 12:33
Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants