fix(#1639): ensure tree autocommands match filetype as well as name #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of buffer" This reverts commit e713607.
|
Test cases:
|
kyazdani42
reviewed
Oct 10, 2022
lua/nvim-tree.lua
Outdated
| create_nvim_tree_autocmd("BufWipeout", { | ||
| pattern = "NvimTree_*", | ||
| callback = function() | ||
| if api.nvim_buf_get_option(0, "filetype") == "NvimTree" then |
There was a problem hiding this comment.
vim.bo.filetype is more luaish
There was a problem hiding this comment.
vim.bo.filetype is also a shorthand for vim.bo[0].filetype.
There was a problem hiding this comment.
Fantastic. I might merge these checks into is_nvim_tree_buf.
alex-courtis
changed the base branch from
1629-cannot-start-with-buffer-named-NvimTree
to
master
kyazdani42
approved these changes
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1639
requires #1629
requires #1632
requires #1637
Autocommands are firing for buffers named
*NvimTree_*which are real files.