fix(#2624): open file from docked floating window #2627
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
commented
Jan 13, 2024
| @@ -24,7 +24,7 @@ function M.get_node_at_cursor() | |||
| return | |||
| end | |||
|
|
|||
| local cursor = vim.api.nvim_win_get_cursor(view.get_winnr()) | |||
There was a problem hiding this comment.
Not strictly necessary.
This was referenced Jan 20, 2024
shiroyasha
reviewed
Jan 23, 2024
| @@ -473,7 +473,7 @@ end | |||
| function M.get_winnr(tabpage) | |||
| tabpage = tabpage or vim.api.nvim_get_current_tabpage() | |||
| local tabinfo = M.View.tabpages[tabpage] | |||
| if tabinfo ~= nil then | |||
| if tabinfo ~= nil and vim.api.nvim_win_is_valid(tabinfo.winnr) then | |||
There was a problem hiding this comment.
@alex-courtis I'm hunting down a bug that seems to be related to this change. Can you help me out in figuring out what is the problem? 🙏
What I currently know is that when I call:
api.node.open.replace_tree_buffer
I get the following error:
E5108: Error executing lua: ...config/nvim/plugged/nvim-tree.lua/lua/nvim-tree/view.lua:476: Expected Lua number
stack traceback:
[C]: in function 'nvim_win_is_valid'
...config/nvim/plugged/nvim-tree.lua/lua/nvim-tree/view.lua:476: in function 'get_winnr'
....config/nvim/plugged/nvim-tree.lua/lua/nvim-tree/lib.lua:22: in function 'get_node_at_cursor'
....config/nvim/plugged/nvim-tree.lua/lua/nvim-tree/api.lua:61: in function <....config/nvim/plugged/nvim-tree.lua/lua/nvim-tree/api.lua:60>
Do you maybe have an idea where should I look next?
There was a problem hiding this comment.
This change did indeed surface some issues, many thanks for digging into this!
Can you log the value of tabinfo.winnr? As of current master it's nil checked, however anything could be in there.
We could just do a type(tabinfo.winnr) == "number"...
#2628 will do away with a lot of these issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2624