fix(#2733): escape trash path

[alex-courtis]

fixes #2733

[gegoune]

There were some changes to paths handling on Neovim master recently that might be relevant here, but I didn't follow them up very closely, just FYI.

[alex-courtis]

There were some changes to paths handling on Neovim master recently that might be relevant here, but I didn't follow them up very closely, just FYI.

Any hints as to what I could look for?

Rather than using fnameescape directly we could have vim.fn.jobstart escape it for us, something like this:

    local job = vim.fn.jobstart({ "gio", "trash", node.absolute_path }, {

That's how we escape paths for vim.fn.system, vim.loop.spawn etc.

Unfortunately we would need to find a way to split config.trash.cmd into a list.

[gegoune]

Any hints as to what I could look for?

I think those are the two that I meant:
neovim/neovim#28105
neovim/neovim#28064

[alex-courtis]

I think those are the two that I meant: neovim/neovim#28105 neovim/neovim#28064

Today I learned about vim.fs. Guessing it's recently added.

We're not using it but should probably migrate some of our fnamemodify calls and utils like path_basename

[alex-courtis]

On further review it seems we should use the fit for purpose shellescape rather than fnameescape.