Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(view): check wins are floating #863

Merged
merged 1 commit into from Dec 24, 2021
Merged

fix(view): check wins are floating #863

merged 1 commit into from Dec 24, 2021

Conversation

rcarriga
Copy link
Contributor

Just adds a check to see if any of the other windows are not floating before closing nvim-tree.

Raised in nvim-notify in rcarriga/nvim-notify#45 and also fixes the issue #859

kyazdani42
kyazdani42 approved these changes Dec 24, 2021
View reviewed changes
Copy link
Member

@kyazdani42 kyazdani42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix :)

@kyazdani42 kyazdani42 merged commit bb12c70 into nvim-tree:master Dec 24, 2021
@kyazdani42 kyazdani42 mentioned this pull request Dec 24, 2021
Closed
Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this pull request Oct 11, 2022
@rcarriga
fix(view): check wins are floating (nvim-tree#863)
1e2e16d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyazdani42 kyazdani42 kyazdani42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rcarriga @kyazdani42