Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update svelte icon #91

Closed
Theo-Steiner opened this issue Oct 12, 2021 · 2 comments · Fixed by #229
Closed

Update svelte icon #91

Theo-Steiner opened this issue Oct 12, 2021 · 2 comments · Fixed by #229

Comments

@Theo-Steiner
Copy link

Hello, thank you for writing this Plugin!
For some reason, the default icon displayed for .svelte is a lying red glyph, that has very little to do with the logo of the language. I tried looking into this myself but I can't seem to get this to work, so perhaps you could update the icon in general?
I saw an Issue for an icon for "teal" so I thought perhaps you could help with this.
The correct icon for svelte would be:
This one, which was recently merged into devicons.
Thank you!

@kyazdani42
Copy link
Member

kyazdani42 commented Oct 12, 2021

these are svg files, doesn't work in terminals. It should be supported by a font like here

@Theo-Steiner
Copy link
Author

these are svg files, doesn't work in terminals. It should be supported by a font like here

I see! Thank you for clarifying and sorry for the very late response. This means that introducing the svelte icon depends on nerd fonts upgrading its icon dependencies (see #ryanoasis/nerd-fonts/issues/615), which most likely seems to be happening with the planned 3.0 release of nerd-fonts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants