Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: Svelte (original, plain, original-wordmark, plain-wordmark) #705

Merged
merged 10 commits into from
Jun 28, 2021

Conversation

Utkarsh1504
Copy link
Contributor

issue #354 #615

@Thomas-Boi Thomas-Boi changed the base branch from master to develop June 28, 2021 19:59
@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection labels Jun 28, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

Couldn't find an icon matching the name in the PR title.

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@Thomas-Boi Thomas-Boi changed the title new icon: Svelte(original, plain, original-wordmark, plain-wordmark) new icon: Svelte (original, plain, original-wordmark, plain-wordmark) Jun 28, 2021
@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jun 28, 2021
@github-actions

This comment has been minimized.

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jun 28, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Utkarsh1504,

Great job on the icons! Everything looks great.

Just two things to keep in mind for future PR: please make sure the base branch is develop rather than master. Also, make sure that the title is new icon: Icon_name () with a space around the Icon name. This will make check the icons faster.

@Thomas-Boi Thomas-Boi merged commit 0679408 into devicons:develop Jun 28, 2021
@amacado amacado mentioned this pull request Aug 14, 2021
@Utkarsh1504 Utkarsh1504 deleted the add-svelte branch August 31, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants