fix: Display context when injected language is not supported #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwaszczuk
force-pushed
the
bugfix/skip-unsupported-languages
branch
from
346d83b
to
db8be70
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #400
Previously, when encountering an unsupported language (one without defined queries) while supporting injected languages, the plugin would abort execution. This behavior wasn't intentional, as even if a specific language isn't supported, we can still leverage insights from both parent and child languages to provide valuable context.
I've identified two approaches to address the unsupported language case. We can either maximize the amount of insights served to the user by skipping unsupported languages, or we can halt further evaluation once an unsupported language was found, displaying only the context calculated so far (replacing the
returnstatement withbreak).While the difference between the two approaches is mostly theoretical and applicable mainly to files with multiple injected languages, including one unsupported, I opted for the "skipping" approach. Its implementation isn't much more complicated than the other one, and potentially offers a better user experience.