Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the upper node gets matched against values from
config.patterns.default
usingget_type_pattern()
which returns a regexp (i.e. the original value, sayfunction
gets returned as%f[%w]function%f[^%w]
having been wrapped withword_pattern()
): this means that key['function']
inlast_types
must be wrapped this same way (as[word_pattern('function')]
) because its finally gets retrieved withlast_types[type]
.Note also that
function_declaration
may be deeply nested insidefunction_definition
(at least, in C), and therefore a correct implementation requires a recursive traversal of nodes which is implemented with functionfind_node()
introduced in this commit.Closes #65