Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have to use augroup to customize highlight groups #120

Closed
sainnhe opened this issue Jun 29, 2020 · 2 comments · Fixed by #121
Closed

Have to use augroup to customize highlight groups #120

sainnhe opened this issue Jun 29, 2020 · 2 comments · Fixed by #121
Assignees
Labels
enhancement New feature or request

Comments

@sainnhe
Copy link
Contributor

sainnhe commented Jun 29, 2020

Is your feature request related to a problem? Please describe.

Commit 282e18e added support for custom highlight groups, I'm trying to make my color scheme support this plugin.

However, I have to use augroup to get it work, see this commit.

I think using augroup is not a good solution, the custom hi groups should be placed in colors/colorscheme.vim. My color scheme supports some other enhanced syntax highlighting plugins such as chromatica, vim-lsp-cxx-highlight and semshi, they don't need an augroup and just work if I place the code in colors/colorscheme.vim.

Describe the solution you'd like

The code for custom highlight groups should work when I place them in colors/colorscheme.vim without an augroup.

Describe alternatives you've considered

Additional context

To reproduce it, edit the color scheme you are using in your init.vim. Restart nvim, and the custom hi groups won't be applied.

@sainnhe sainnhe added the enhancement New feature or request label Jun 29, 2020
@theHamsta theHamsta assigned theHamsta and vigoux and unassigned theHamsta Jun 29, 2020
@vigoux
Copy link
Member

vigoux commented Jun 29, 2020

Could you try #121, it solved the issue on my side, but having you testing it will give use more confidence in it 😉

sainnhe added a commit to sainnhe/gruvbox-material that referenced this issue Jun 29, 2020
@sainnhe
Copy link
Contributor Author

sainnhe commented Jun 29, 2020

Yeah, I can confirm that it can be fixed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants