Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto: deprecate used_by in parsers.lua #2471

Merged

Conversation

kyazdani42
Copy link
Member

@kyazdani42 kyazdani42 commented Feb 6, 2022

TODO: should i create a public function to modify this list instead of providing the user with the table ?

  • remove print_warning function from utils.lua (unused)
  • cleanup some functions in parsers.lua (shadowing parameters and wrong
    bufnr used).
  • log a deprecation notice when using used_by in a parser definition
  • default the filetype_to_parsername table to the list of filetypes
    previously in the used_by keys
  • update the README to indicate that change

fixes #2373

@theHamsta
Copy link
Member

theHamsta commented Feb 6, 2022

Can you also post this in #2293 after merge? Alltough deprecating is not breaking (yet ...)

- remove print_warning function from utils.lua (unused)
- cleanup some functions in parsers.lua (parameters overloading
  and wrong bufnr used).
- log a deprecation notice when using used_by in a parser definition
- default the filetype_to_parsername table to the list of filetypes
  previously in the used_by keys
- update the README to indicate that change
@kyazdani42 kyazdani42 merged commit 58a4897 into nvim-treesitter:master Feb 6, 2022
@kyazdani42 kyazdani42 deleted the refacto/deprecate-used-by branch February 6, 2022 13:31
@JSchrtke JSchrtke mentioned this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsers used_by doesn't work for html parser
3 participants